Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix versions & runtime in navbar #215

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Fix versions & runtime in navbar #215

merged 1 commit into from
Jul 25, 2023

Conversation

gonzamontiel
Copy link
Contributor

Closes #144

@gonzamontiel gonzamontiel linked an issue Jul 25, 2023 that may be closed by this pull request
Fix Dapp, Runtime and Network #144
Closed
@netlify
Copy link

netlify bot commented Jul 25, 2023 •
edited
Loading

✅ Deploy Preview for rococo-souffle-a625f5 ready!

Name Link
🔨 Latest commit ccd85b4
🔍 Latest deploy log https://app.netlify.com/sites/rococo-souffle-a625f5/deploys/64bfafcbe280150008fb224c
😎 Deploy Preview https://deploy-preview-215--rococo-souffle-a625f5.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@gonzamontiel gonzamontiel requested a review from ebma July 25, 2023 11:19
ebma
ebma approved these changes Jul 25, 2023
View reviewed changes
Copy link
Member

@ebma ebma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Would be better of course if the last block number actually updated with every new block but I think that's too much effort for such a minor detail.

@gonzamontiel gonzamontiel merged commit ce0cab0 into staging Jul 25, 2023
5 checks passed
@gonzamontiel gonzamontiel deleted the 144-fix-dapp-runtime-and-network branch July 25, 2023 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebma ebma ebma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Dapp, Runtime and Network
2 participants
@gonzamontiel @ebma